Skip to content

chore: migrate to tsdown #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: migrate to tsdown #760

wants to merge 1 commit into from
+577 −540

Conversation

@sxzz
Copy link

@sxzz sxzz commented Oct 5, 2025 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

tsup is not actively maintained anymore, migrating to new alternative tsdown.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2025
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.00%. Comparing base (972aa9e) to head (edde608).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   61.00%   61.00%           
=======================================
  Files          35       35           
  Lines        2921     2921           
  Branches      463      463           
=======================================
  Hits         1782     1782           
  Misses       1139     1139
Flag Coverage Δ
4.8.4 58.61% <ø> (ø)
latest 60.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 7, 2025
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, there are build failures in Node.js 18. ts-api-utils still supports 18 in the current major. We haven't discussed plans to release a new one to breaking-change drop support for Node.js 18. Is this a blocker?

@sxzz
Copy link
Author

sxzz commented Oct 7, 2025

This is because rolldown and tsdown do not support bundling in node 18, but his outputs will not be affected. Therefore, we need to find a way to test and run the outputs by tsdown in node18.

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Oct 7, 2025

👍 if you can figure that out, great! I haven't looked deeply.

@sxzz sxzz marked this pull request as draft October 7, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Migrate to tsdown

2 participants

@sxzz @JoshuaKGoldberg